Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tmp folder to .gitignore #2938

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Dec 16, 2023

What does this pull request do? Explain your changes. (required)

This pull request adds the tmp folder generated when running tests to the .gitignore file.

Specific updates (required)

  • Add tmp to .gitignore.

How did you test each of these updates (required)

I checked if this pull request did not include the tmp folder.

Does this pull request close any open issues?

Checklist:

@@ -8,6 +8,9 @@
# Test binary, build with `go test -c`
*.test

# Misc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask for another place to add this entry or another header.

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd never noticed this, but looks like I have tmp in my global .gitignore - thanks for the fix!

@thomshutt thomshutt merged commit 8a8b0e3 into livepeer:master Dec 18, 2023
16 of 17 checks passed
@rickstaa rickstaa deleted the add_tmp_to_gitignore branch December 18, 2023 10:07
@thomshutt thomshutt mentioned this pull request Jan 29, 2024
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
* chore: add tmp folder to .gitignore

* chore: add CHANGELOG_PENDING.md entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants