Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging from metrics methods #2948

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Remove logging from metrics methods #2948

merged 2 commits into from
Jan 10, 2024

Conversation

thomshutt
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Remove logging that's just recording the fact we've emitted a metric. All of the information in these lines is duplicated in other logging.

How did you test each of these updates (required)

  • Ran unit tests

Does this pull request close any open issues?
No

Checklist:

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f4ee24) 56.33564% compared to head (5b505ea) 56.35850%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2948         +/-   ##
===================================================
+ Coverage   56.33564%   56.35850%   +0.02286%     
===================================================
  Files             89          89                 
  Lines          19485       19470         -15     
===================================================
- Hits           10977       10973          -4     
+ Misses          7898        7887         -11     
  Partials         610         610                 
Files Coverage Δ
monitor/census.go 63.76471% <ø> (+0.43138%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4ee24...5b505ea. Read the comment docs.

Files Coverage Δ
monitor/census.go 63.76471% <ø> (+0.43138%) ⬆️

@thomshutt thomshutt requested a review from leszko January 10, 2024 12:00
@thomshutt thomshutt merged commit ffc491a into master Jan 10, 2024
18 checks passed
@thomshutt thomshutt deleted the less-logging branch January 10, 2024 13:09
@thomshutt thomshutt mentioned this pull request Jan 29, 2024
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
* Remove logging from metrics methods

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants