eth,eth/watcher: Create Chainlink price feed watcher #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@victorges would it maybe be possible to use Chainlink library instead of creating go bindings on our own? |
victorges
force-pushed
the
vg/feat/usd-price-per-unit
branch
from
a8f62e5
to
9e35aef
Compare
victorges
changed the title
victorges
changed the title
victorges
changed the title
victorges
force-pushed
the
vg/feat/usd-price-per-unit
branch
2 times, most recently
from
67be5cb
to
67286d8
Compare
Makefile: Use mockgen binary from tool dependencies eth/contracts: Add chainlink interfaces source Makefile: Generate Chainlink contracts ABI tools: Add abigen tool to repo eth/contracts: Generate chainlink bindings Makefile: Fix abigen bindings generation Revert everything abigen Turns out there's already bindings exported from the Chainlink lib. go.mod: Add chainlink library eth/watchers: Add pricefeed watcher eth/watchers: Clean-up event watching code eth/watchers: Improve price tracking Revert "go.mod: Add chainlink library" This reverts commit ac415bd. Revert "Revert everything abigen" This reverts commit b7c40b1. eth/contracts: Gen bindings for proxy iface eth/watchers: Use local bindings for contracts eth/watchers: Simplify event subs logic eth/watchers: Simplify&optimize truncated ticker eth/watchers: Update decimals on fetch eth/watchers: Improve handling of decimals eth/watchers: Fix price rat creation eth/watchers: Make sure we use UTC on truncated timer eth/contracts/chainlink: Generate only V3 contract bindings eth/watchers: Watch PriceFeed only with polling eth/watchers: Add a retry logic on price update eth/watchers: Use clog instead of fmt.Printf
This will make the code more testable.
victorges
force-pushed
the
vg/feat/usd-price-per-unit
branch
from
6d36858
to
ae07a11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2972 +/- ##
===================================================
- Coverage 57.37567% 57.24231% -0.13336%
===================================================
Files 89 91 +2
Lines 15402 15513 +111
===================================================
+ Hits 8837 8880 +43
- Misses 5973 6040 +67
- Partials 592 593 +1
Continue to review full report in Codecov by Sentry.
|
Gosh that was much harder than I thought
victorges
force-pushed
the
vg/feat/usd-price-per-unit
branch
from
fbe50b7
to
4db8153
Compare
victorges
force-pushed
the
vg/feat/usd-price-per-unit
branch
from
efc2aca
to
59450bf
Compare
victorges
changed the title
victorges
changed the title
leszko
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Thanks for the PR @victorges . Added some comments. Other than that it looks good.
5 tasks
leszko
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This creates a new client in the eth package to fetch and watch a Chainlink PriceFeed.
This will be used by go-livepeer to be able to peg the transcoding price in an alternate currency,
mostly the American dollar, for a more predictable cost and revenue for node operators.
The logic for using this pricefeed info into tuning the price dynamically will be done in a separate PR.
Specific updates (required)
ethpkg, for basic fetching of price from a price feedeth/watcherspkg, to keep up to date on pricing changesHow did you test each of these updates (required)
go testDoes this pull request close any open issues?
Implements ENG-1725
Checklist:
makeruns successfully./test.shpass