server: Allow Os price to increase up to 2x mid-session #2995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to allow O prices to increase up to a given threshold (currently 2x)
in the middle of a session.
With #2892, we intended to make the session prices fixed, but since deploying
#2981 we noticed that some sessions are getting dropped due to these prices
changing anyway. So there is some other flow that is updating those prices and
we need to investigate and fix them.
To avoid rolling back on the USD-based price improvement, I'm proposing this
change so we can roll the behavior forward while we find the source of changing
prices in the B<->O logic. There is a risk of still dropping sessions but it should
not be significant over the few days until we make the protocol fix.
Specific updates (required)
How did you test each of these updates (required)
Ran automated tests.
Does this pull request close any open issues?
Related to ENG-1855 but a bit parallel to that
Checklist:
make
runs successfully./test.sh
pass