Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Allow Os price to increase up to 2x mid-session #2995

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

victorges
Copy link
Member

@victorges victorges commented Apr 2, 2024

What does this pull request do? Explain your changes. (required)
This is to allow O prices to increase up to a given threshold (currently 2x)
in the middle of a session.

With #2892, we intended to make the session prices fixed, but since deploying
#2981 we noticed that some sessions are getting dropped due to these prices
changing anyway. So there is some other flow that is updating those prices and
we need to investigate and fix them.

To avoid rolling back on the USD-based price improvement, I'm proposing this
change so we can roll the behavior forward while we find the source of changing
prices in the B<->O logic. There is a risk of still dropping sessions but it should
not be significant over the few days until we make the protocol fix.

Specific updates (required)

  • Allow O pries to increase up to 2x since session start
  • Fix/update tests

How did you test each of these updates (required)
Ran automated tests.

Does this pull request close any open issues?
Related to ENG-1855 but a bit parallel to that

Checklist:

@victorges victorges changed the base branch from master to vg/fix/max-price-check April 2, 2024 18:50
@victorges victorges changed the title Vg/feat/o price vary threshold server: Allow Os price to increase up to 2x mid-session Apr 2, 2024
Copy link

linear bot commented Apr 2, 2024

@victorges victorges requested a review from leszko April 2, 2024 19:05
@victorges victorges marked this pull request as ready for review April 2, 2024 19:05
@victorges victorges force-pushed the vg/feat/o-price-vary-threshold branch from 663a83f to d7f84cb Compare April 2, 2024 19:19
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from vg/fix/max-price-check to master April 3, 2024 11:44
@victorges victorges force-pushed the vg/feat/o-price-vary-threshold branch from d7f84cb to a7ced72 Compare April 3, 2024 11:45
@victorges victorges merged commit 119f346 into master Apr 3, 2024
14 checks passed
@victorges victorges deleted the vg/feat/o-price-vary-threshold branch April 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants