refactor: rename internal references from Broadcaster to Gateway

[rickstaa]

What does this pull request do? Explain your changes. (required)

This pull request updates internal references from 'Broadcaster' to 'Gateway' in accordance with the core team’s decision. For more details, refer to the discussion: Discord
Link.

It follows up on #3056 as I noticed I forgot to rename some references.

Specific updates (required)

• Renames some internal references of Broadcaster to Gateway in the livepeer.go and starter.go files.

How did you test each of these updates (required)

I checked the tests were successful and started a off-chain orchestrator and gateway.

Does this pull request close any open issues?

NO

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.40929%. Comparing base (e8f079e) to head (95418ef).

Additional details and impacted files

@@              Coverage Diff              @@
##              master       #3060   +/-   ##
=============================================
  Coverage   57.40929%   57.40929%           
=============================================
  Files             92          92           
  Lines          15764       15764           
=============================================
  Hits            9050        9050           
  Misses          6111        6111           
  Partials         603         603           

Files	Coverage Δ
cmd/livepeer/livepeer.go	50.98039% <100.00000%> (ø)
cmd/livepeer/starter/starter.go	7.90514% <0.00000%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f079e...95418ef. Read the comment docs.

Files	Coverage Δ
cmd/livepeer/livepeer.go	50.98039% <100.00000%> (ø)
cmd/livepeer/starter/starter.go	7.90514% <0.00000%> (ø)

[rickstaa]

@victorges I noticed in #2981 hat you added the following line:

go-livepeer/cmd/livepeer/starter/starter.go

Line 796 in b739f35

p := p

Since there's no goroutine or defer statement inside the loop that could cause a closure over the loop variable, we can safely remove the p := p line I think.

[victorges]

Hey @rickstaa!
Even tho there's no explicit go or defer statements there, there is a closure on this anonymous function sent to that auto updater:

go-livepeer/cmd/livepeer/starter/starter.go

Line 799 in b739f35

glog.Infof("Price: %v wei per pixel for broadcaster %v", price.FloatString(3), p.EthAddress)

And that updater itself might start a goroutine that eventually runs that function.

Do you think this could be made clear in some way?

[rickstaa]

Hey @rickstaa! Even tho there's no explicit go or defer statements there, there is a closure on this anonymous function sent to that auto updater:

go-livepeer/cmd/livepeer/starter/starter.go

Line 799 in b739f35

glog.Infof("Price: %v wei per pixel for broadcaster %v", price.FloatString(3), p.EthAddress)

And that updater itself might start a goroutine that eventually runs that function.

Do you think this could be made clear in some way?

@victorges Ah, I think I had been programming for too long when I asked that question and overlooked the anonymous function 🤦🏻. Thanks for your explanation! I think in that case we are good to merge this 👍🏻.

[victorges]

LGTM