Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: protect Docker 'stable' tag (#3062)" #3067

Closed
wants to merge 1 commit into from

Conversation

leszko
Copy link
Contributor

@leszko leszko commented May 29, 2024

Reverting your PR @rickstaa , because it stopped building docker images.

@leszko leszko requested review from mjh1 and rickstaa May 29, 2024 13:41
@rickstaa
Copy link
Contributor

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

@hjpotter92
Copy link
Member

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

the default branch for this repo is not main 😅

@rickstaa
Copy link
Contributor

@leszko, please feel free to merge this pull request or my new one: PR #3068. This one is working, as you can see from the successful actions run: link.

@rickstaa
Copy link
Contributor

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

the default branch for this repo is not main 😅

Good catch will fix it now 👍🏻.

@leszko
Copy link
Contributor Author

leszko commented May 29, 2024

Cool, thanks @rickstaa . Merged your PR and closing this one.

@leszko leszko closed this May 29, 2024
@rickstaa rickstaa deleted the rafal/revert-docker branch May 29, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants