Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django object level permissions support #253

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

dirkmoors
Copy link

This PR will add support for the object level permission "view_".

This is very useful when integrating this library in a project that uses e.g. Django Guardian to handle the permissions: https://django-guardian.readthedocs.io/en/stable/userguide/assign.html#prepare-permissions

@coveralls
Copy link

coveralls commented Sep 21, 2016

Coverage Status

Coverage increased (+0.1%) to 66.723% when pulling e8c392a on dirkmoors:feature/django-guardian-support into bfb0ccc on llazzaro:develop.

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.1%) to 66.89% when pulling 4e355aa on dirkmoors:feature/django-guardian-support into 4d45a0c on llazzaro:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 67.354% when pulling 089226f on dirkmoors:feature/django-guardian-support into edcf2c0 on llazzaro:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 67.354% when pulling 089226f on dirkmoors:feature/django-guardian-support into edcf2c0 on llazzaro:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 67.354% when pulling 089226f on dirkmoors:feature/django-guardian-support into edcf2c0 on llazzaro:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 67.446% when pulling f0c04a8 on dirkmoors:feature/django-guardian-support into 0c4bda3 on llazzaro:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 28, 2016

Coverage Status

Coverage increased (+0.1%) to 67.446% when pulling f0c04a8 on dirkmoors:feature/django-guardian-support into 0c4bda3 on llazzaro:develop.

@llazzaro
Copy link
Owner

@dirkmoors I will like to merge this. I will do it for next release if possible. I will rename migration since the 0003 is already in use. thanks

Copy link
Collaborator

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would it be reasonable to add test with integrated Guardian support to avoid this being refactored away?

Needs to be rebased.

@@ -6,3 +6,4 @@
/dist/
/django_scheduler.egg-info/
/docs/_build/
.idea/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line? It looks unrelated to the PR of adding object level permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants