The cancer is gone -- phase 1 #38
Conversation
| - local_postgres_data:/var/lib/postgresql/data | ||
| - local_postgres_data_backups:/backups | ||
| - local_postgres_data:/var/lib/postgresql/data:cached | ||
| - local_postgres_data_backups:/backups:cached |
There was a problem hiding this comment.
How often is the backup updated. Does it make sense to cache it?
There was a problem hiding this comment.
If I'm totally honest, I have no idea. According to that article, the difference should be imperceptible to the user. I haven't really pushed on it that much but after I did this (and restarted Docker) it really improved the performance.
There was a problem hiding this comment.
I'm going to say to uncache the backups but keep postgresql cached, since the backup isn't read from very often.
|
Hahahahahahaha nice. Looks great |
| - local_postgres_data:/var/lib/postgresql/data | ||
| - local_postgres_data_backups:/backups | ||
| - local_postgres_data:/var/lib/postgresql/data:cached | ||
| - local_postgres_data_backups:/backups:cached |
There was a problem hiding this comment.
I'm going to say to uncache the backups but keep postgresql cached, since the backup isn't read from very often.
|
I want to wait to merge this until phase 2 is done so that there isn't confusion about duplicate phone number fields |
|
Totally agree |
Phase 1 generates a new class,
PatientPhoneNumber, that represents a phone number for a patient. Adding phone numbers is now done with a '+' sign on the patient detail view.Phase 2 will actually remove the old phone numbers, after we copy everything over using the python shell.
PatientPhoneNumberwith link toPatientobjectphone_numbertoUserPatientPhoneForm,phonenumber_fieldfor handling phone numbers.PHONENUMBER_DEFAULT_REGIONcontrols default country codelocal.ymlto adddelegated,cachedmaybe improving MacOS performance?