added backup documentation and workup script #76
Conversation
| If you are on windows and the above command doesn't work, delete the headings in the script files you are calling, rebuild and run the server, and then use the command: | ||
| :: | ||
|
|
||
| docker exec -it llemr_postgres_1 /bin/bash usr/local/bin/backup |
There was a problem hiding this comment.
Are you able to confirm that deleting the headings is necessary? If it is necessary, would it be valid to delete the headings across the board? Having two different versions of the files for different operating systems is not something that I want to have happen
There was a problem hiding this comment.
Where exactly is llemr_postgres_1 coming from? This name seems hardcoded, and I wouldn't be surprised if it was different from one person's computer to another. You should detail how to get that name
| This command will copy the backups you have created to your local machine: | ||
| :: | ||
|
|
||
| docker cp llemr_postgres_1:./backups . |
|
|
||
| docker exec -it llemr_postgres_1 /bin/bash usr/local/bin/backup | ||
|
|
||
| Note: If you want to view all of the backups you have created in the postgres container, replace backup with backups in the above commands |
There was a problem hiding this comment.
It's better to paste the command again
| @@ -0,0 +1,26 @@ | |||
| Creating Backups and Copy to Host | |||
There was a problem hiding this comment.
Can you provide documentation on how to load backups as well?
| @@ -1,6 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
|
|
|||
| countdown() { | |||
There was a problem hiding this comment.
Don't edit unnecessary files to adjust whitespace
| @@ -3,13 +3,10 @@ | |||
| # This file only contains a selection of the most common options. For a full | |||
| # list see the documentation: | |||
| # https://www.sphinx-doc.org/en/master/usage/configuration.html | |||
|
|
|||
| Instructions for running this script are located in (PUT THE PLACE THAT I PUT THE DOC FILE IN) [note: I need to make docs for this] | ||
| """ |
There was a problem hiding this comment.
You need to do this before I can approve the pull request
| workup_one = WorkupFactory() | ||
| workup_two = WorkupFactory() | ||
| workup_three = WorkupFactory() | ||
|
|
||
| workup_one.written_datetime = d1 | ||
| workup_two.written_datetime = d2 | ||
| workup_three.written_datetime = d3 |
There was a problem hiding this comment.
you should be able to specify the written datetime when creating the workup. If this is not already allowed, you should edit WorkupFactory to allow this
| from .factories import WorkupFactory | ||
| import datetime | ||
|
|
||
| class testScripts(TestCase): |
There was a problem hiding this comment.
This class name sounds generic, also the first letter should be capitalized. Something like TestUtilityScripts could work
|
|
||
| fixtures = ['workup', 'core'] | ||
|
|
||
| def test_workup_date_checker(self): |
There was a problem hiding this comment.
I don't understand how this test works when you don't specify the encounter date for the test workups.
There was a problem hiding this comment.
You should add an additional tests to check individual functions, such as whether the differ by n days function works for exactly n days
|
Make sure to delete the binary file as well |
No description provided.