Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2102R0: Make "implicit expression variations" more explicit (Wording for US185) #100042

Closed
cjdb opened this issue Jul 23, 2024 · 2 comments
Closed

P2102R0: Make "implicit expression variations" more explicit (Wording for US185) #100042

cjdb opened this issue Jul 23, 2024 · 2 comments
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev wg21 paper Issues representing the implementation of a WG21 paper

Comments

@cjdb
Copy link
Contributor

cjdb commented Jul 23, 2024 •
edited
Loading

Link: https://wg21.link/p2102r0

This was implemented from the beginning.
@cjdb cjdb added good first issue https://github.com/llvm/llvm-project/contribute libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. c++20 labels Jul 23, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 23, 2024

@llvm/issue-subscribers-c-20

Author: Christopher Di Bella (cjdb)

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Jul 23, 2024 •
edited
Loading

This paper doesn't seem strictly "Nothing to do" to me. It enforced some expression variants in copyable and indirectly_copyable_storable to be checked - so that there're some substitution failures or hard errors that would cause IFNDR-ness without this paper.

I think it should be considered completed in 15.0, after implementing both copyable (in LLVM 13, 8ef69c6, https://reviews.llvm.org/D97443) and indirectly_copyable_storable (in LLVM 15, e65d376, https://reviews.llvm.org/D118432).

@cjdb cjdb changed the title Confirm 'P2102R0 Make ‘implicit expression variations’ more explicit (Wording for US185)' should be marked as 'Nothing to do' in the status page Confirm 'P2102R0 Make ‘implicit expression variations’ more explicit (Wording for US185)' is a no-op Jul 26, 2024
@ldionne ldionne added the wg21 paper Issues representing the implementation of a WG21 paper label Jul 30, 2024
@cjdb cjdb added potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev and removed good first issue https://github.com/llvm/llvm-project/contribute labels Aug 1, 2024
@ldionne ldionne changed the title Confirm 'P2102R0 Make ‘implicit expression variations’ more explicit (Wording for US185)' is a no-op P2102R0: Make "implicit expression variations" more explicit (Wording for US185) Aug 1, 2024
@llvm llvm deleted a comment from llvmbot Aug 28, 2024
@llvm llvm deleted a comment from llvmbot Aug 28, 2024
5c4lar pushed a commit to 5c4lar/llvm-project that referenced this issue Aug 29, 2024
@ldionne @5c4lar
[libc++] Mark a few papers as done or "Nothing To Do"
af4bb47 
Please refer to the Github issues for details on why those are marked
as resolved. Huge thanks to @frederick-vs-ja for the analysis.

Closes llvm#104336
Closes llvm#100042
Closes llvm#100615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev wg21 paper Issues representing the implementation of a WG21 paper
Projects
libc++ Standards Conformance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ldionne @cjdb @frederick-vs-ja @llvmbot