Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDGPU] Assembler cannot handle v_mad_u32_u24 with relocated operand #100075

Closed
jayfoad opened this issue Jul 23, 2024 · 2 comments · Fixed by #100103
Closed

[AMDGPU] Assembler cannot handle v_mad_u32_u24 with relocated operand #100075

jayfoad opened this issue Jul 23, 2024 · 2 comments · Fixed by #100103
Assignees
@arsenm
Labels
backend:AMDGPU

Comments

@jayfoad
Copy link
Contributor

jayfoad commented Jul 23, 2024

With this test case I get:

$ llc -mtriple=amdgcn -mcpu=gfx1100 r.txt -o - | llvm-mc -triple=amdgcn -mcpu=gfx1100
	.text
	.section	.AMDGPU.config,"",@progbits
	.long	47176
	.long	1613692928
	.long	47180
	.long	0
	.long	47200
	.long	0
	.long	4
	.long	0
	.long	8
	.long	0
	.text
	.globl	f
	.p2align	8
	.type	f,@function
f:
	v_dual_mov_b32 v1, 0 :: v_dual_and_b32 v0, 1, v0
	s_delay_alu instid0(VALU_DEP_1)
unhandled operand type
UNREACHABLE executed at /home/jayfoad2/git/llvm-project/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:8655!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.

The instruction it fails on is v_mad_u32_u24 v0, v0, 12, g0@abs32@lo
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 23, 2024

@llvm/issue-subscribers-backend-amdgpu

Author: Jay Foad (jayfoad)

With this [test case](https://github.com/user-attachments/files/16345638/r.txt) I get: ``` $ llc -mtriple=amdgcn -mcpu=gfx1100 r.txt -o - | llvm-mc -triple=amdgcn -mcpu=gfx1100 .text .section .AMDGPU.config,"",@progbits .long 47176 .long 1613692928 .long 47180 .long 0 .long 47200 .long 0 .long 4 .long 0 .long 8 .long 0 .text .globl f .p2align 8 .type f,@function f: v_dual_mov_b32 v1, 0 :: v_dual_and_b32 v0, 1, v0 s_delay_alu instid0(VALU_DEP_1) unhandled operand type UNREACHABLE executed at /home/jayfoad2/git/llvm-project/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:8655! PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace. ``` The instruction it fails on is `v_mad_u32_u24 v0, v0, 12, g0@abs32@lo`

@jayfoad
Copy link
Contributor Author

jayfoad commented Jul 23, 2024

@arsenm arsenm self-assigned this Jul 23, 2024
arsenm added a commit that referenced this issue Jul 23, 2024
@arsenm
AMDGPU: Fix assembler asserting on expressions in vop3 instructions
f9e02fb 
Fixes #100075
@arsenm arsenm mentioned this issue Jul 23, 2024
Merged
arsenm added a commit that referenced this issue Jul 23, 2024
@arsenm
AMDGPU: Fix assembler asserting on expressions in vop3 instructions
0510315 
Fixes #100075
arsenm added a commit that referenced this issue Jul 23, 2024
@arsenm @jayfoad
AMDGPU: Fix assembler asserting on expressions in vop3 instructions (#…
81e2a57 
…100103)

Fixes #100075

---------

Co-authored-by: Jay Foad <[email protected]>
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this issue Jul 23, 2024
@arsenm @jayfoad @sgundapa
AMDGPU: Fix assembler asserting on expressions in vop3 instructions (l…
dd6a1a5 
…lvm#100103)

Fixes llvm#100075

---------

Co-authored-by: Jay Foad <[email protected]>
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@arsenm @yuxuanchen1997
AMDGPU: Fix assembler asserting on expressions in vop3 instructions (#…
3cd085b 
…100103)

Summary:
Fixes #100075

---------

Co-authored-by: Jay Foad <[email protected]>

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arsenm arsenm

Labels
backend:AMDGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AMDGPU: Fix assembler asserting on expressions in vop3 instructions llvm/llvm-project
3 participants
@jayfoad @arsenm @llvmbot