Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly support GritLM #3432

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Explicitly support GritLM #3432

wants to merge 12 commits into from

Conversation

janEbert
Copy link

@janEbert janEbert commented Jul 2, 2024

Why are these changes needed?

Fix GritLM:

  • Chat template is now correct.
  • Embedding now works correctly, values match the GritLM README example exactly.
  • In order to make it easy on users, the general embedding tokens are prepended automatically if no instruction is given. So it's impossible to embed without the embedding instruction.

Related issue number (if applicable)

Ref #3181, which mentions support for embedding models.

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

@surak
Copy link
Collaborator

surak commented Jul 2, 2024

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surak surak surak approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janEbert @surak