Warn on RP forest degenerescence #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some datasets have such properties as to yield poor random projection trees, where branching does not divide the data very well. In such cases, one gets one-leaf branches and what remains is a large leaf monolith. One approach is to carry on dividing deeper, but the ill is done nonetheless, as these tiny branches can still cause problems. Thus, when the random projection recursion fails to yield a tree where all leaves satisfy the leaf size constraint, we will drop this tree. Should we drop *all* the trees, we will revert to random initialisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some datasets have such properties as to yield poor random projection trees, where branching does not divide the data very well. In such cases, one gets one-leaf branches and what remains is a large leaf monolith. One approach is to carry on dividing deeper, but the ill is done nonetheless, as these tiny branches can still cause problems. Thus, when the random projection recursion fails to yield a tree where all leaves satisfy the leaf size constraint, we will drop this tree. Should we drop all the trees, we will revert to random initialisation.