New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample only the reversed neighbour #43

Open

yupbank wants to merge 2 commits into lmcinnes:master from yupbank:fix-sampling-from-the-paper

yupbank commented May 9, 2019 •

edited

Loading

Right now we sample both the neighbours and reversed neighbours. Following the paper, we only sample the reversed neighbours with rho ?

But the overall max_candidates is really interesting. i think it's a innovation from the code/practitioner

I think the origin paper missed a big detail, that the reversed neighbours would suffer from both too many and too little.

yupbank added 2 commits

May 9, 2019 14:32


          Sampling only the reversed neighbor

b3617bb


          also update the thread version

cbc8150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet