add identity validation, del Campaigns APIs #275
Conversation
jho44
force-pushed
the
identityValidation
branch
from
8152747
to
14f1330
Compare
| apiClient.setBasePath(BASE_PATH); | ||
| basicAuth.setUsername(LOB_API_KEY); | ||
| return apiClient; |
There was a problem hiding this comment.
@jho44 What is the purpose of all the extra code here? It seems like both use these lines.
There was a problem hiding this comment.
One of the functions uses the TEST KEY for integration tests while the other (previously undefined) uses the LIVE KEY for integration tests. I was following precedent with older SDK tests. But in hindsight, it would've been DRYer to pass "live" or "test" as a parameter to one function that chooses between the keys based on the parameter. Should I do that instead? I'll need to edit all other files that use the getConfigForIntegration function.
There was a problem hiding this comment.
@jho44 Nope it's ok it must be the weird layout in GH, it looked like they were doing the exact same thing. This is fine the way it is. Thanks!
ticket
Added Identity Validation API and tests
Regen SDK
Deleted Campaign APIs