Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/snap packs #276

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Feat/snap packs #276

wants to merge 15 commits into from

Conversation

richseviora
Copy link

@richseviora richseviora commented Feb 26, 2024 •
edited

Description

This PR enables snap packs and various other endpoints.

Story

CMB-323

Related PR's

Generator TBD

Verify

  • Code runs without errors
  • Tests pass with >=85% coverage

@guardrails GuardRails
Copy link

guardrails bot commented Feb 26, 2024 •
edited

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@richseviora richseviora marked this pull request as ready for review February 27, 2024 20:26
@richseviora richseviora requested a review from a team as a code owner February 27, 2024 20:26
@richseviora richseviora requested review from bamohan and removed request for a team February 27, 2024 20:26
bamohan
bamohan approved these changes Feb 28, 2024
View reviewed changes
Copy link

@bamohan bamohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Plz also have someone from the team approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamohan bamohan bamohan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richseviora @bamohan