feat(yarn): adds yarn + upgrades eslint #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsachen
commented
Apr 25, 2018
| @@ -0,0 +1,1296 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
Is it common to include the yarn.lock for npm packages? I noticed some of our packages didn't.
There was a problem hiding this comment.
If you use yarn to build, I'm pretty sure you have to commit it.
https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for
marklee22
approved these changes
Apr 25, 2018
sjl2
reviewed
Apr 26, 2018
.circleci/config.yml
Outdated
|
|
||
| - run: | ||
| name: Enforce coverage | ||
| command: ./scripts/enforce_coverage.sh |
There was a problem hiding this comment.
nit: this may be nice to have as yarn script of yarn enforce
There was a problem hiding this comment.
Also, don't we usually do this with a flag in yarn test?
There was a problem hiding this comment.
Are you referring to istanbul?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based off #5, see diff for changes.
What
eslintandeslint-config-lobeslint-plugin-lobyarn.lock