fix if no source but target

locize · Dec 10, 2021 · e4d9aca · e4d9aca
1 parent 51cdbcf
commit e4d9aca
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 5.7.2
+
+- fix if no source but target
+
 ### 5.7.1
 
 - a bit friendlier when not having target values

diff --git a/lib/js2xliff.js b/lib/js2xliff.js
@@ -56,7 +56,8 @@ function createGroupUnitTag (id, group) {
 
 function createUnitTag (id, unit) {
   const segment = makeElement('segment', null, true)
-  segment.elements.push(makeElement('source', null, makeValue(unit.source, ElementTypes2)))
+  if (!unit.source && unit.target) unit.source = ''
+  if (unit.source) segment.elements.push(makeElement('source', null, makeValue(unit.source, ElementTypes2)))
   if (unit.target !== undefined) segment.elements.push(makeElement('target', null, makeValue(unit.target, ElementTypes2)))
   const subEle = [segment]
   if ('note' in unit) {

diff --git a/lib/jsToXliff12.js b/lib/jsToXliff12.js
@@ -74,7 +74,8 @@ function createTransUnitTag (key, resource, obj, options) {
       'xml:lang': obj.sourceLanguage
     }
   }
-  u.elements.push(makeElement('source', sourceAttributes, makeValue(resource.source, ElementTypes12)))
+  if (!resource.source && resource.target) resource.source = ''
+  if (resource.source) u.elements.push(makeElement('source', sourceAttributes, makeValue(resource.source, ElementTypes12)))
   if (resource.target != null) {
     let targetAttributes = null
     if (options.xmlLangAttr && obj.targetLanguage) {

diff --git a/xliff.js b/xliff.js
@@ -503,7 +503,8 @@ function createGroupUnitTag(id, group) {
 
 function createUnitTag(id, unit) {
   var segment = (0, _objectToXml.makeElement)('segment', null, true);
-  segment.elements.push((0, _objectToXml.makeElement)('source', null, (0, _objectToXml.makeValue)(unit.source, _ElementTypes.default)));
+  if (!unit.source && unit.target) unit.source = '';
+  if (unit.source) segment.elements.push((0, _objectToXml.makeElement)('source', null, (0, _objectToXml.makeValue)(unit.source, _ElementTypes.default)));
   if (unit.target !== undefined) segment.elements.push((0, _objectToXml.makeElement)('target', null, (0, _objectToXml.makeValue)(unit.target, _ElementTypes.default)));
   var subEle = [segment];
 
@@ -638,7 +639,8 @@ function createTransUnitTag(key, resource, obj, options) {
     };
   }
 
-  u.elements.push((0, _objectToXml.makeElement)('source', sourceAttributes, (0, _objectToXml.makeValue)(resource.source, _ElementTypes.default)));
+  if (!resource.source && resource.target) resource.source = '';
+  if (resource.source) u.elements.push((0, _objectToXml.makeElement)('source', sourceAttributes, (0, _objectToXml.makeValue)(resource.source, _ElementTypes.default)));
 
   if (resource.target != null) {
     var targetAttributes = null;

diff --git a/xliff.min.js b/xliff.min.js