Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure jsToXliff functions generate valid xliff files #58

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

AdriAt360
Copy link
Contributor

Fixes #57

The jsToXliff libs create xliff with wrong format in case of falsy source, e.g. "". In this situation, the generated xliff contains no source tag, which is not valid against the specification, image

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added -> no change needed for this fix, the doc is accurate

@adrai adrai merged commit 881f1f5 into locize:master Feb 26, 2024
4 checks passed
@adrai
Copy link
Contributor

adrai commented Feb 26, 2024

thank you... it's included in v6.2.1

@AdriAt360
Copy link
Contributor Author

@adrai thanks a lot for your reactivity here 🙏🏽

@AdriAt360 AdriAt360 deleted the master-57 branch February 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The jsToXliff12 lib creates xliff with wrong format in case of falsy source
2 participants