Fix calculation of h/n for 2D cases #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test |
|
It turns out that the issue might be in the way we check if a mesh is 2D. I will look into the implementation of horses3d/Solver/src/libs/mesh/HexMesh.f90 Line 1619 in def829a We are apparently considering some meshes as 2D even if not specifically stated in the control file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are computing h/n assuming that the cases are always 3D. With this PR, the value of h/n in 2D cases is correct as long as the extruded dimension is 1.
We use this when computing artificial viscosity and LES.