Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit and e2e tests #36

Closed
wants to merge 19 commits into from
Closed

add unit and e2e tests #36

wants to merge 19 commits into from

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Jun 23, 2024

  • Move helper functions from main.go to handler.go in order to be able to test them
  • Add Unit tests
    • functions that use cloudwatch client are tested in the E2E test
  • Add E2E test

8naama added 17 commits June 23, 2024 12:26
@8naama
add unit and e2e tests
94887ac
@8naama
update tests commands
dc46ec1
@8naama
add sort to the array to prevent order from failing the test
85b1dba
@8naama
fix working directory path for build zip
33b27cf
@8naama
update aws user permissions
62aa6cc
@8naama
add customLogGroups param to the command
27c4d13
@8naama
add AWS_DEFAULT_REGION env variable to try avoid 255 issue with AWS C…
1962b6b 
…LI v2
@8naama
add debug logs
26050ca
@8naama
add CAPABILITY_NAMED_IAM capability
67e16bc
@8naama
disable rollback for debug purpose
87bdcfc
@8naama
add CGO_ENABLED=0 to tru resolve issue with GLIBC_2.34 and prevent te…
60b3e5f 
…st files from being copied to the zip
@8naama
update commands
1d390d4
@8naama
update commands
70a00db
@8naama
update commands after extra test
e7932b5
@8naama
change order of the test data and stack creation
78ea2ad
@8naama
add extra call to generate the log group
396c624
@8naama
fix call to api_id in customLogGroup
d58da58
@8naama 8naama requested a review from yotamloe June 30, 2024 13:40
yotamloe
yotamloe requested changes Jun 30, 2024
View reviewed changes
Copy link

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job :) see my comments

tests/e2e_test.go Outdated Show resolved Hide resolved
eventbridge-lambda/handler/handler.go Outdated
@@ -0,0 +1,64 @@
package handelr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be handler

eventbridge-lambda/handler/handler_test.go Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@8naama 8naama mentioned this pull request Jul 1, 2024
Merged
@8naama 8naama closed this in #39 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamloe yotamloe yotamloe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@8naama @yotamloe