refactor: remove obsolete All class (#338)

loophp · Feb 20, 2024 · a7e549f · a7e549f
1 parent acb6d8f
commit a7e549f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 50 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -42,20 +42,6 @@
       <code><![CDATA[(new Operation\Product())()(...$iterables)]]></code>
     </MixedArgument>
   </file>
-  <file src="src/Operation/All.php">
-    <InvalidReturnStatement>
-      <code><![CDATA[static fn (bool $normalize): Closure =>
-                /**
-                 * @param iterable<TKey, T> $iterable
-                 *
-                 * @return Generator<int, T>|Generator<TKey, T>
-                 */
-                static fn (iterable $iterable): Generator => yield from ($normalize ? (new Normalize())()($iterable) : $iterable)]]></code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code><![CDATA[Closure(bool): Closure(iterable<TKey, T>): (Generator<int, T>|Generator<TKey, T>)]]></code>
-    </InvalidReturnType>
-  </file>
   <file src="src/Operation/DropWhile.php">
     <InvalidArgument>
       <code><![CDATA[$callbacks]]></code>

diff --git a/src/Collection.php b/src/Collection.php
@@ -50,7 +50,7 @@ private function __construct(callable $callable, iterable $parameters = [])
 
     public function all(bool $normalize = true): array
     {
-        return iterator_to_array((new Operation\All())()($normalize)($this));
+        return iterator_to_array($this, !$normalize);
     }
 
     public function append(mixed ...$items): CollectionInterface

diff --git a/src/Operation/All.php b/src/Operation/All.php