-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Psalm Annotations #101
Conversation
@@ -367,7 +367,7 @@ public function frequency(): CollectionInterface | |||
* @template NewTKey | |||
* @template NewT | |||
* | |||
* @param callable(...mixed): Iterator<NewTKey, NewT> $callable | |||
* @param callable(mixed ...$parameters): iterable<NewTKey, NewT> $callable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
the
...mixed
syntax is not supported by PHPStan, but themixed ...$parameters
is supported by both Psalm and PHPStan -
also note the collection can be instantiated with a callable returning any
iterable
, not justIterator
, as exemplified in the SA check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Any clue what we could do about the unit tests failing on macOS? Have you seen this phpspec error before?
|
This is temporary, I guess it will be fixed upstream very soon. I guess we can agree to ignore it for now. ok ? |
Yeah that's fine. This is ready otherwise, but take your time to review again as it's quite big 😄 |
This PR is just #95 with fixes for the code analysis.