-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MapN | Deprecate Map With Multiple Callbacks | Static Analysis Checks #112
Conversation
9c1be2a
to
2755a42
Compare
@drupol hey, let me know if this looks good to you and I will update the documentation as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alex,
Thanks for this PR !
I was about to give the approval but then I had an idea.
Instead of throwing the exception in the Operation class Map
, why not throwing it from Collection::map()
?
Wouldn't it be better? WDYT?
Hey, thanks for reviewing! I considered that, however it's not sufficient because the library provides the Operations to be used separately. So someone that will use the operation directly like this also needs to know about the deprecation if used with multiple callbacks. That's why I also had to update this usage to |
You're perfectly right, that was a bad idea :) Can't wait to be in version 5 to remove the ugly |
@drupol hey, added documentation now and addressed comments, this should be ready 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add here, all good :)
This PR introduces
MapN
based on the discussions in #77, and deprecatesMap
usage with multiple callbacks.MapN
code (same asMap
but with moremixed
type hints)Map
with multiple callbacksMap
stays backwards compatible