-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Matching operation and implements Selectable from Doctrine. #115
Conversation
cfef956
to
8783b22
Compare
tag me when this is ready, I'll want to review :) |
8783b22
to
b84c761
Compare
424a3aa
to
aba42a9
Compare
aba42a9
to
1c4428f
Compare
Co-authored-by: Alex Gidei <[email protected]>
Co-authored-by: Alex Gidei <[email protected]>
Regarding this, I think it could be implemented in a follow-up PR with a callback provided by the user. I don't think it should be done "by default", and also we don't have access to the entity manager, right? The user would have to provide that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this 💯
Thanks! |
This PR
Collection::matching(Criteria $criteria)
operationTo investigate: