Trim Static Analysis Baselines #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
commented
Jul 5, 2021
Comment on lines
+82
to
+85
| if (null !== $this->key) { | ||
| unset($this->indexes[$this->key]); | ||
| $this->key = key($this->indexes); | ||
| } |
There was a problem hiding this comment.
@drupol let me know if this looks right to you. If the key is null then the unset will not have any effect anyway
There was a problem hiding this comment.
Psalm's catch 😄
|
thanks! |
|
Thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Psalm baseline and the PHPStan Docs baseline, which is not in use anymore because the
docsfolder is ignored.