Add All Operation #133
Merged
Add All Operation #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
commented
Jul 11, 2021
| @@ -26,31 +24,31 @@ final class Pipe extends AbstractOperation | |||
| /** | |||
| * @pure | |||
| * | |||
| * @return Closure(...callable(Iterator<TKey, T>):Generator<TKey, T, mixed, mixed>):Closure(Iterator<TKey, T>):Iterator<TKey, T> | |||
| * @return Closure(callable(iterable<TKey, T>): iterable<TKey, T> ...): Closure(iterable<TKey, T>): iterable<TKey, T> | |||
There was a problem hiding this comment.
I expanded the type here from Iterator to iterable to allow for the All usage, which returns an array
added 3 commits
July 11, 2021 17:36
|
Thanks 👯♂️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
AlloperationEven though this is a simple one, it's good to have it in an operation so that users that want to use the operations separately can benefit from it and don't have to use
iterator_to_arrayall the time.