Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent warning when using odd amount of items. #154

Merged
merged 2 commits into from
Jul 18, 2021
Merged

Fix: Prevent warning when using odd amount of items. #154

merged 2 commits into from
Jul 18, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 18, 2021 •
edited
Loading

This PR:

  • Fix warnings when using the Pair operation and when having an odd number of items in the collection.
  • Has unit tests (phpspec)

@drupol drupol added the bug Something isn't working label Jul 18, 2021
@drupol drupol self-assigned this Jul 18, 2021
@drupol drupol marked this pull request as ready for review July 18, 2021 17:37
@drupol drupol requested a review from AlexandruGG July 18, 2021 17:37
@drupol drupol removed their assignment Jul 18, 2021
AlexandruGG
AlexandruGG approved these changes Jul 18, 2021
View reviewed changes
Copy link
Collaborator

@AlexandruGG AlexandruGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@drupol drupol merged commit cc52f3d into master Jul 18, 2021
@drupol drupol deleted the fix/prevent-warning-with-pair-operation branch July 18, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drupol @AlexandruGG