refactor: Update Window operation in point free style.
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
changed the title
Window operation in point free style.
AlexandruGG
reviewed
Aug 18, 2021
AlexandruGG
reviewed
Aug 22, 2021
Comment on lines
+4050
to
+4052
| // Unsupported - but tested. | ||
| $this::fromIterable(range('a', 'e')) | ||
| ->window(-2) |
There was a problem hiding this comment.
what about the window(-1) case? That one is mentioned now in the docs so sounds like it's supported -> we should have a test for it
|
@drupol I think you merged the wrong one? 😅 |
|
Oh. Sorry :( Indeed I messed up... too many tabs open here. |
|
I'll add a new test in the master branch directly in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Windowin point free style.$sizeis zero, which is more in sync with what the Window operation does and avoid mixing types (T|list<T>=>list<T>)Before:
Collection::fromIterable(['a', 'b', 'c'])->window(0); // ['a', 'b', 'c']After:
Collection::fromIterable(['a', 'b', 'c'])->window(0); // [['a'], ['b'], ['c']]