-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update Zip
operation in point free style.
#181
Conversation
979865f
to
8055c07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drupol this one feels like another case where things are increasing in complexity and more dependencies added (Pipe, Reduce, Flatten), especially if we compare to the previous form which was relatively simple.
What's the benefit of doing this? And is there any way to make things a bit more readable?
This library is about transformations, and I think we should emphasize that in the code. I also consider this as a challenge in order to be succinct and to express pipelined computations as a composition of functions rather than thinking of threading arguments through each other. Actually I found this very readable, it's just a matter of habits, that said, I will make a slight modification tonight that will make it a bit more easier to read :) |
Pull request was converted to draft
Pull request was converted to draft
0710540
to
e3cceed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drupol Thanks for the explanation and the little refactor!
I completely understand your view of the transformations and the beauty of composing functions to achieve them. I think the new form is definitely clearer in what it's doing 😁
Feel free to merge this, I'm not hitting "approve" so you get the chance to check the other comment 😄
Co-authored-by: Alex Gidei <[email protected]>
This PR:
Zip
in point free style.