Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation #84

Merged
merged 5 commits into from
May 16, 2021
Merged

Update Documentation #84

merged 5 commits into from
May 16, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR updates the API documentation and README with details similar to other examples.

AlexandruGG
AlexandruGG commented May 15, 2021
View reviewed changes
README.md Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/pages/api.rst Show resolved Hide resolved
docs/pages/api.rst Show resolved Hide resolved
drupol
drupol approved these changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this approval comment, I hit the wrong button!

drupol
drupol requested changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made a review. All those changes are great!

There's a small things to update, as soon as it's ok, I merge this.

drupol
drupol requested changes May 16, 2021
View reviewed changes
docs/pages/api.rst Outdated Show resolved Hide resolved
docs/pages/api.rst Outdated Show resolved Hide resolved
docs/pages/api.rst Outdated Show resolved Hide resolved
@drupol drupol added the bug Something isn't working label May 16, 2021
drupol
drupol previously approved these changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this, I'm very grateful !

@AlexandruGG
Copy link
Collaborator Author

Thanks!

I made a review. All those changes are great!

There's a small things to update, as soon as it's ok, I merge this.

Thank you, agreed the suggested change to that example makes it clearer 👍

@AlexandruGG AlexandruGG marked this pull request as ready for review May 16, 2021 07:59
@AlexandruGG
Copy link
Collaborator Author

Thanks for taking the time to do this, I'm very grateful !

I appreciate all the work that you've already put in this project! 💯

@drupol drupol merged commit f6ef7f9 into loophp:master May 16, 2021
@drupol
Copy link
Collaborator

drupol commented May 16, 2021

Thanks again :)

@AlexandruGG AlexandruGG deleted the update-docs branch May 16, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexandruGG @drupol