Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add benchmarks Makefile #2

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Dec 19, 2021

add a Makefile with commands to help running benchmarks.

@azjezz azjezz requested a review from drupol as a code owner December 19, 2021 20:34
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :) Thanks !!!

@@ -77,7 +77,11 @@ private function test(Traversable $input): void
}

if ($b !== $c) {
throw new Exception('$a !== $b');
throw new Exception('$b !== $c');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh! I've been too hasty once again!

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I forgot, could you update the .gitattributes file to prevent shipping the Makefile on production.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks !

@drupol drupol merged commit 7ad6266 into loophp:main Dec 19, 2021
@azjezz azjezz deleted the chore/bench-makefile branch December 19, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants