Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixupPhase flag to fix the cmake copy issue #397

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Thieso
Copy link

@Thieso Thieso commented Apr 23, 2024

Fixes #391

But does this break anythink else? Is this a good fix?

@wentasah
Copy link
Contributor

I think this should not break anything. Packages from this overlay are built with moveLib64 hook enabled so lib64 should always be a symlink to lib. buildEnv just creates one more level of symlinks, which should be fine.

The only downside I can see is that this approach may consume more i-nodes for symlinks than necessary. Creating one symlink from ...ros-env/lib64 to lib should be sufficient, but this creates full tree of new symlinks. But I don't think it's a problem for anybody.

@hacker1024
Copy link
Contributor

I'm a little concerned about potential performance impacts here. buildEnv is already quite slow, especially on devices with low-end storage.

@Thieso
Copy link
Author

Thieso commented Apr 29, 2024

Fair, so would there be an easier way to achieve this? Maybe force overwriting of redundant files?

@wentasah
Copy link
Contributor

wentasah commented Apr 29, 2024

I tried quick&dirty way of building all humble packages and only two of those, which build successfully, contain lib64. Namely foonathan-memory-vendor and google-benchmark-vendor. They together contain 23 entries in lib64, so the overhead created by buildEnv symlinks will be negligible.

Edit: With rolling, the situation is exactly the same.

@Thieso
Copy link
Author

Thieso commented May 13, 2024

Would be great if this could be merged :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moveit Packages in Iron: Ros-env cmake copy issue
3 participants