Python qt bindings support both #416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this patch is still needed for some QUI apps to work, including rqt, in the newly generated jazzy and rolling distros. |
|
shiboken2 is now marked broken with python312 NixOS/nixpkgs@603c034 sip4 is also disabled for python312 NixOS/nixpkgs@544c197 |
|
ROS2 meta ticket involving upgrade from qt5 -> qt6, which would solve these 3.12 compatibility issues ros2/ros2#1452 |
Pleune
force-pushed
the
python-qt-bindings-support-both
branch
from
6ab5028
to
4f3e76d
Compare
In ros-visualization/python_qt_binding@e78372f, the sip_configure.py cmake helper script in python-qt-binding was updated to live-patch the QtCoremod.sip file in a temp directory. Which is the same change that is applied from the aur here. The live patch thing breaks the build as it is writing to a file outside of the nix build area. Remove that write and apply the patch from the AUR. Also moved the ros1 rviz pyqt patch into the regular python-qt-binding overlay to allow any downstream packages to have functional pyqt if that is what ends up being used.
Pleune
force-pushed
the
python-qt-bindings-support-both
branch
from
4f3e76d
to
46f3d14
Compare
|
Submitted PR upstream to update sip4 and pyside2/shiboken2 to support Python312. NixOS/nixpkgs#327976 With these changes, I can now open and use rqt with all the plugins with 3.12 from current nixpkgs/master, using either backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been bounding around trying to get all of the pyqt stuff to work across all of the distros for a while now... and I think this is my final solution. It seems to keep everything happy, and works even for the most current versions of everything, without requiring any huge overrides, or any patches that will break when files are updated upstream.
Some packages need specifically pyqt or pyside to be loaded by python-qt-binding. This changes the overrides to support both.
Annoyingly, in recent python-qt-binding releases, sip_configure.py, the cmake helper script, rewrites QtCoremod.sip, which is outside of the nix build area and causes a build failure. See ros-visualization/python_qt_binding@e78372f
This is the same patch that is applied from the AUR here. So sed patch out these changes. Then move the ros1 rviz patch to distro-overlay.nix to apply to everything.
Tested with:
See #404