ament-cmake-vendor-package: don't 'fix' cmake files #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pleune
force-pushed
the
ament_cmake_vendor_package_dont_fix_cmake
branch
2 times, most recently
from
8899187
to
bfaca4f
Compare
|
Rebased and add patch for Jazzy. This is still needed to support rmw_zenoh. |
|
This should go in |
Pleune
force-pushed
the
ament_cmake_vendor_package_dont_fix_cmake
branch
from
bfaca4f
to
05c79f9
Compare
|
Updated to apply in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ament cmake vendoring works by downloading files into the
ros2_ws/install/opt/<package>folder, which is a local path. It then sets theCMAKE_PREFIX_PATHto point into this directory. However, the normal nixpkgs cmake setup renames the /opt/ chunk with /var/empty, which then breaks the CMAKE_PREFIX_PATH setup. since this is a local install, just dont "fix" the cmake paths.I noticed this by trying to build https://github.com/ros2/rmw_zenoh, which uses the ament cmake vendoring, and therefore just simply does not build without this patch.
I had to apply this in the distro overlay files, as the vendoring package does not exist in foxy.