Bugfix/memory usage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luissimas
force-pushed
the
bugfix/memory-usage
branch
from
3fc236b
to
452813a
Compare
Codecov ReportAttention: Patch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
The current implementation of go-git has a high memory cost. Since our needs are not that complex, we can use the default git CLI. Reference: go-git/go-git#315
luissimas
force-pushed
the
bugfix/memory-usage
branch
from
e02ac18
to
f10808c
Compare
|
After replacing the go-git implementation with using the git CLI we can see a significant drop in memory usage. The exporter now uses approximately half the memory and its usage is much more stable. The cost of this is that now we have to install git on the final docker image, but since I've replaced the distroless debian base with alpine the final image size is now 37.1MB, a few megabytes smaller than before.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the memory usage of the exporter.
Closes #15