Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed exception message for bad topology graph #521

Merged
merged 10 commits into from
Feb 13, 2024

Conversation

andrewtarzia
Copy link
Collaborator

@andrewtarzia andrewtarzia commented Feb 12, 2024

Related Issues: #463 #462
Requested Reviewers: @lukasturcani
Note for Reviewers: If you accept the review request add a 👍 to this post

This is a simple PR that starts the process of adding more clear errors as issues ok with construction with stk. Just helping the user as they build new topology graphs.

@lukasturcani we should discuss the format an exception class if you think this is a good idea.

@andrewtarzia andrewtarzia marked this pull request as ready for review February 12, 2024 14:42
@lukasturcani lukasturcani enabled auto-merge (squash) February 13, 2024 09:16
@lukasturcani lukasturcani changed the title Add more detailed exception message for bad topology graph. Add more detailed exception message for bad topology graph Feb 13, 2024
@lukasturcani lukasturcani merged commit 1627838 into lukasturcani:master Feb 13, 2024
7 of 8 checks passed
@andrewtarzia andrewtarzia deleted the add_error branch February 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FG representation in building blocks now shows as the factory class, not the resulting functional groups.
2 participants