Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle allPages option being passed as string. #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomfordweb
Copy link

Hello,

Thank you for sharing this plugin. I am using Gatsby 4.12.1.

There seems to be a typecasting issue with the default value for the onPostBuild method allPages param.

This was being passed to the script as a string of "false" with this configuration. For what it's worth, omitting the allPages: false and relying on the default parameter value is broken as well without this fix.

    {
      resolve: "gatsby-plugin-pdf",
      options: {
        paths: ["/my-pdf/"],
        allPages: false,
        outputPath: "/public/exports",
      },
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant