Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameter placeholders in translations #2187

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

hbugdoll
Copy link
Member

@hbugdoll hbugdoll commented Jan 8, 2024

What are you changing/introducing

Fixed parameter placeholders in Bulgarian, Hungarian and Romanian translations for Yii::t().

What is the reason for changing/introducing

Parameter placeholder names were accidentally translated, e.g. {attribute}{атрибутът}.

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues

@nadar
Copy link
Member

nadar commented Jan 8, 2024

thanks!

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a change log entrie in core/CHANGELOG.md referring to this PR? Thanks

@hbugdoll
Copy link
Member Author

hbugdoll commented Jan 8, 2024

can you please add a change log entrie in core/CHANGELOG.md referring to this PR? Thanks

Done.

@nadar
Copy link
Member

nadar commented Jan 9, 2024

thanks! @hbugdoll

@nadar nadar merged commit 62c5162 into luyadev:master Jan 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants