-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI setup #5
Merged
Merged
Fix CI setup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable caching - Move things out of script files, and into the .travis.yml file - Use "jobs" key, so that we can name each job
80efa16
to
e66f48b
Compare
To fix cross compile issues (and also, it's faster to call objc_retain directly instead of using a selector)
Note: The function was also UB before (`RustObjCExceptionThrow` would need to be marked with `C-unwind`)
b1c0b17
to
f61e86e
Compare
They have wider OS support than GitHub Actions, but they also give less free build minutes Also fixes the iOS tests
The linker is smart enough to figure out that we are not using any symbols from the Foundation library, and elides the request to link it. To circumvent this, we define a (unused) function referencing the symbol for NSObject
I've used up my free credits and getting MacOS credits were more expensive than i thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitions to GitHub Actions, albeit with the Travis CI setup kept in repo for posterity because they have much better support for older macOS versions. Replaces SSheldon/rust-objc#99.
Also changes GNUStep setup with commits from 8fc644a and SSheldon/rust-objc-foundation#6.
Had to pull in SSheldon/rust-objc-exception#8 and SSheldon/rust-objc-exception#10 (which I intended to do anyways, so it's fine) to fix various compilation issues.