New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning when WARN_CREATE_GLOBAL is active #41

Merged

mafredri merged 1 commit into mafredri:master from agkozak:agkozak-warn-create-global

May 14, 2020

Contributor

agkozak commented May 14, 2020

Version 1.8.2's $errfd has to be declared as a local variable, or else we get the warning

async_start_worker:37: numeric parameter errfd created globally in function async_start_worker

when the zsh option WARN_CREATE_GLOBAL is on.


          Avoid warning when WARN_CREATE_GLOBAL is active

3aa5bb2

mafredri approved these changes

View reviewed changes

Owner

mafredri left a comment

Super, thanks for catching this and submitting a PR!

mafredri merged commit fa94826 into mafredri:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet