Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure we are using the real cat #47

Merged
merged 3 commits into from
Oct 23, 2020
Merged

fix: ensure we are using the real cat #47

merged 3 commits into from
Oct 23, 2020

Conversation

jtyers
Copy link
Contributor

@jtyers jtyers commented Oct 22, 2020

Fixes #44

@jtyers jtyers mentioned this pull request Oct 22, 2020
Closed
mafredri
mafredri reviewed Oct 23, 2020
View reviewed changes
async.zsh Outdated Show resolved Hide resolved
@jtyers
Copy link
Contributor Author

jtyers commented Oct 23, 2020

Good shout, thought I was missing a trick. Updated to use command -p, so we use a standard value for $PATH

mafredri
mafredri approved these changes Oct 23, 2020
View reviewed changes
Copy link
Owner

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit on the fence about -p, but I think it was a good choice to add it in 👍🏻.

Thanks!

@mafredri mafredri merged commit c18959a into mafredri:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang when cat is aliased to bat
2 participants
@jtyers @mafredri