Correct behavior with multiple players #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notwaldorf
reviewed
Mar 2, 2020
notwaldorf
requested changes
Mar 2, 2020
| */ | ||
| seekTo(seconds: number) { | ||
| if (!this.isPlaying()) { |
There was a problem hiding this comment.
Not sure about this one either. You can definitely seek while the player is paused or stopped. I would remove this
There was a problem hiding this comment.
Same as above: isPlaying() returns true when the player is paused. And when it's stopped, you can't resume() it anymore; you can only call start() which will start playing from time 0. Am I correct?
There was a problem hiding this comment.
In any case, we don't want to allow doing anything with the Transport when the player is stopped, because it might affect some other player.
notwaldorf
approved these changes
Mar 4, 2020
|
(I'll do a release now that has all of your recent changes, thanks so much for them!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks to
BasePlayerto make sure only one player is active at a given time. An error is thrown if an action would put the player in an inconsistent state. Fixes #403.