Add offset parameter to player.start #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh I like this a lot. let me try to restart the travis job to see if the tests failed because of a fluke |
|
Argh, I can't restart the build (because "an error occurred" 🤦♀️). Would you mind doing a rebase (to trigger a new build?). Thanks (and sorry about the pain)! |
|
No problem, done! |
notwaldorf
reviewed
Jan 7, 2021
notwaldorf
approved these changes
Jan 25, 2021
|
@notwaldorf Thanks for merging! Any plans for a release? It would be awesome to have these changes available! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an
offsetparameter to enable starting the sequence from a given time.This will allow me to implement a workaround for my seeking problem in html-midi-player. Related: #502.