Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unselected components are not cleared in text editor #108

Closed
magjac opened this issue Jun 7, 2019 · 1 comment
Closed

Unselected components are not cleared in text editor #108

magjac opened this issue Jun 7, 2019 · 1 comment
Assignees
@magjac
Labels
bug Something isn't working
Projects
Graphviz Visual Editor short-term act...

Comments

@magjac
Copy link
Owner

magjac commented Jun 7, 2019

When selecting a component in the graph, it is highlighted in the text editor, but when deselecting it, the highlighting of it is not cleared.

This bug does not exist in version 0.6.0. Only when updating the dependencies. It was introduced when react-ace was upgraded to version 6.5.0 by this PR.
magjac pushed a commit that referenced this issue Jun 8, 2019
Fix unselected components not cleared in text editor
d7db1e7 
#108
@magjac magjac mentioned this issue Jun 8, 2019
Merged
@magjac magjac self-assigned this Jun 8, 2019
@magjac magjac added the bug Something isn't working label Jun 8, 2019
@magjac magjac added this to To do in Graphviz Visual Editor short-term activities via automation Jun 8, 2019
@magjac
Copy link
Owner Author

magjac commented Jun 8, 2019

Fixed by d7db1e7.

@magjac magjac closed this as completed Jun 8, 2019
Graphviz Visual Editor short-term activities automation moved this from To do to Done and merged but not yet released Jun 8, 2019
@magjac magjac changed the title Unselected component are not cleared in text editor Unselected components are not cleared in text editor Jun 8, 2019
@magjac magjac moved this from Done and merged but not yet released to Done in latest release in Graphviz Visual Editor short-term activities Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magjac magjac

Labels
bug Something isn't working
Projects
Graphviz Visual Editor short-term act...
  
Done in latest release
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magjac