Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characters are lost in the editor when typing fast and DOT parsing errors occur #22

Closed
magjac opened this issue Aug 27, 2018 · 2 comments
Closed

Characters are lost in the editor when typing fast and DOT parsing errors occur #22

magjac opened this issue Aug 27, 2018 · 2 comments
Assignees
@magjac
Labels
bug Something isn't working
Projects
Graphviz Visual Editor short-term act...

Comments

@magjac
Copy link
Owner

magjac commented Aug 27, 2018

The reason is that the mechanism that inserts the error marker in the editor gutter also re-insert the latest text exported from the editor which might not be up-to-date when typing fast.
@magjac magjac added the bug Something isn't working label Aug 27, 2018
@magjac magjac self-assigned this Aug 27, 2018
@magjac magjac moved this from To do to In progress in Graphviz Visual Editor short-term activities Aug 28, 2018
magjac added a commit that referenced this issue Aug 29, 2018
@magjac
Try to parse DOT and don't attempt to render if parsing fails
28b4f2b 
This speeds up feedback for erroneus DOT and reduces the risk of
triggering #22
@magjac magjac mentioned this issue Aug 29, 2018
Merged
@magjac
Copy link
Owner Author

magjac commented Aug 29, 2018 •
edited
Loading

This bug is not fixed, but the risk of triggering it has been significantly reduced by d0c44e9 and 28b4f2b. Also, 196e4e3 introduces the possibility for the user to increase the editor hold-off time to reduce the risk even further.

@magjac magjac moved this from In progress to To do in Graphviz Visual Editor short-term activities Aug 29, 2018
@magjac magjac moved this from To do to In progress in Graphviz Visual Editor short-term activities Aug 29, 2018
@magjac magjac moved this from In progress to To do in Graphviz Visual Editor short-term activities Aug 29, 2018
magjac added a commit that referenced this issue Sep 11, 2018
@magjac
Don't clear error until DOT parsing succeeds
dd9ad28 
Fixes #22
@magjac magjac mentioned this issue Sep 11, 2018
Merged
Graphviz Visual Editor short-term activities automation moved this from To do to Done Sep 11, 2018
@magjac magjac assigned magjac and unassigned magjac Sep 19, 2018
@magjac magjac mentioned this issue May 26, 2019
Closed
@mcp292
Copy link

mcp292 commented Jun 15, 2023

I am still experiencing this. I will try to come back with reproducible examples as I encounter them.

One is node [ -> node.

@magjac magjac mentioned this issue Nov 5, 2023
Closed
magjac added a commit that referenced this issue Nov 15, 2023
@magjac
fix lost characters when typing fast and DOT parsing errors occur
0062951 
Fixes #236 and
#22 which was
only partially fixed by d0c44e9 and
28b4f2b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magjac magjac

Labels
bug Something isn't working
Projects
Graphviz Visual Editor short-term act...
  
Done but not yet merged
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magjac @mcp292