Operation Node refactor #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
radudum10
commented
Aug 12, 2022
radudum10
commented
- operation_node.py classes are now in separated files and some of them have been completely refactored.
- I have fixed the dependencies between the classes.
- This is currently still in progress, review and testing are welcome!
Signed-off-by: Cristi Done <[email protected]>
Signed-off-by: Cristi Done <[email protected]>
Signed-off-by: Cristi Done <[email protected]>
Signed-off-by: Cristi Done <[email protected]>
Signed-off-by: Cristi Done <[email protected]>
… details in regex_parser_v3.py & sandbox_regex.py
Docstrings were added for all the functions. A bug caused by an unchecked pointer has been solved. Also, I have renamed functions, variables, extracted duplicate codes, made new functions in order to have a more readable code.
This is how the operation_node will be splitted in multiple files. Each of those files will contain extracted classes from thefile. Also, NonTerminalNode and TerminalNode classes have already been extractedand they are a good way to preview how all the files will look.
|
@radudum10 , this requires rebasing. This is still WIP so commits and commit messages are not that relevant now. But when getting closer to merging the PR, please be sure that:
|
razvand
reviewed
Aug 28, 2022
There was a problem hiding this comment.
Hi, @radudum10 . This is just a first pass. There's quite a lot of code to read, so I will need to take a deeper look. Please find some minor comments.
Also:
- Please add an ending newline at each new file (see my comments).
- Are submodules, and the
.gitmodulesfile, required? - I would remove the
.idea/folder. This is mostly a configuration that should sit outside the project.
|
|
||
| def is_allow_deny(self): | ||
| if self.match.is_terminal() and self.unmatch.is_terminal(): | ||
| return self.match.terminal.is_allow() and self.unmatch.terminal.is_deny() |
| for node_iter in g.keys(): | ||
| rv = rg.get_vertice_by_value(node_iter) | ||
| rg.reduce_graph_with_metanodes() | ||
| return rg |
| return result_str | ||
|
|
||
| def xml_str(self): | ||
| return self.recursive_xml_str(3, False) |
| return self.type == self.TERMINAL_NODE_TYPE_ALLOW | ||
|
|
||
| def is_deny(self): | ||
| return self.type == self.TERMINAL_NODE_TYPE_DENY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.