-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for waste event start and endtime #679
base: master
Are you sure you want to change the base?
Conversation
Please provide some documentation in doc/installation.md @mampfes what do you think about this? |
Sorry, I wouldn't merge this PR. I'm afraid that this hasn't been fully thought through. And I think there are other ways to do, for example, automations for all-day events in the calendar. |
Yes, but let me know if you want to merge it or not before I put in the effort. |
The reason to implement it in the plugin instead of the automation/calendar is simple... Here it has to be implemented in one single place. Otherwise it has to be implemented several times for every component and automation using this feature with multiple locations of the same configuration (like hour offsets). |
The MR adds (optional) support for waste event start and endtime.
My local regulations say that I'm allowed to put the waste out between 20:00 (the day before collection) and 18:00 (on collection day). This way the state of the waste calendar in HA is only 'on' when it's allowed.
In my case the configuration looks like this: