Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to phantomjs v2 #107

Merged
merged 1 commit into from
Feb 16, 2016
Merged

Upgrade to phantomjs v2 #107

merged 1 commit into from
Feb 16, 2016

Conversation

marcbachmann
Copy link
Owner

There are some regression bugs in that phantomjs release that we can't fix.

  • onLongRunningScript and stopJavaScript do not work (issue 12504)
  • OS X 10.6 (Snow Leopard) is not supported anymore (issue 12900)
  • PDF rendering too large, page.zoomFactor doesn't work (issue 12685)

@marcbachmann
Copy link
Owner Author

I think only the last option has an impact on the users.
But as long as it's consistent, it shouldn't matter. This is a breaking change.

marcbachmann added a commit that referenced this pull request Feb 16, 2016
@marcbachmann
Merge pull request #107 from marcbachmann/phantomjs-2
d398df9 
Upgrade to phantomjs v2
@marcbachmann marcbachmann merged commit d398df9 into master Feb 16, 2016
@marcbachmann marcbachmann deleted the phantomjs-2 branch February 16, 2016 22:26
@marcbachmann
Copy link
Owner Author

I've just published that in [email protected]

@djibythiaw
Copy link

What's the best solution for the PDF rendering too large bug ?

@molomby molomby mentioned this pull request Nov 25, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcbachmann @djibythiaw