Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fix #169

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Style fix #169

merged 2 commits into from
Sep 7, 2021

Conversation

theflucs
Copy link

@theflucs theflucs commented Sep 7, 2021

Addressing issue #14
Also regarding closed issue #76

Improved overall card design
Minor style adjustments

Open for more improvements or discussion about what's been done

@vercel
Copy link

vercel bot commented Sep 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/99i3dqiAxs33tkdcL8ZMqQZpV9jL
✅ Preview: https://helpafamily-git-fork-theflucs-style-fix-margaritahumanitarian.vercel.app

@audreyfeldroy
Copy link
Member

This is a wonderful UX improvement @theflucs! I appreciate it so much, and your implementation looks great.

I see from the diff that you ran into the limitations of the current Card model with having to use CardAddress for the volunteer position requirements. Since the scope of this PR is style fixes and it's very successful at that, I'll merge it and file that refactor as a separate issue.

@audreyfeldroy audreyfeldroy merged commit d625969 into margaritahumanitarian:main Sep 7, 2021
@theflucs theflucs deleted the style-fix branch September 7, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants